Skip to content

Add BMAD-guided PR reviewer workflow and slash-command routing#32905

Closed
Copilot wants to merge 10 commits into
mainfrom
copilot/create-pr-code-reviewer-workflow
Closed

Add BMAD-guided PR reviewer workflow and slash-command routing#32905
Copilot wants to merge 10 commits into
mainfrom
copilot/create-pr-code-reviewer-workflow

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 17, 2026

This PR adds a dedicated PR code-review workflow grounded in the BMAD Method so reviews follow a structured, scale-adaptive frame instead of ad hoc heuristics. It also wires the workflow into slash-command routing for on-demand invocation.

  • Workflow: bmad-pr-code-reviewer

    • Added .github/workflows/bmad-pr-code-reviewer.md with PR review triggers (pull_request.ready_for_review) and centralized slash command trigger (/bmad-review).
    • Configured safe outputs for inline review comments and single review submission.
    • Embedded BMAD-oriented review flow in prompt instructions (Discovery → Analysis → Architecture → Delivery Quality), with changed-lines-only scope and severity-first prioritization.

  • Routing integration

    • Regenerated .github/workflows/agentic_commands.yml to register:
      • /bmad-review -> bmad-pr-code-reviewer for PR comment/review comment events.

  • Compiled artifact

    • Added generated lock file: .github/workflows/bmad-pr-code-reviewer.lock.yml.
on:
  pull_request:
    types: [ready_for_review]
  slash_command:
    strategy: centralized
    name: bmad-review
    events: [pull_request_comment, pull_request_review_comment]

Copilot AI and others added 3 commits May 16, 2026 04:36
@pelikhan
Plan BMAD reviewer workflow
52c8591 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Add BMAD PR reviewer workflow definition
ad906a3 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Add BMAD PR reviewer workflow and compiled lock
9e01397 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented May 17, 2026

@copilot merge main and recompile

Copilot AI and others added 2 commits May 17, 2026 21:25
Merge remote-tracking branch 'origin/main' into copilot/create-pr-cod…
5338e35 
…e-reviewer-workflow

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Merge main and recompile BMAD reviewer workflow
c4b1c55 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 17, 2026

@copilot merge main and recompile

Done in c4b1c55. I merged main into this branch and recompiled the BMAD reviewer workflow using the current shared OTLP import.

Copilot AI requested a review from pelikhan May 17, 2026 21:29
@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented May 17, 2026

@copilot merge main, make build, make recompile

Copilot AI and others added 2 commits May 17, 2026 21:36
@pelikhan
Plan: merge main and rebuild workflows
9c97f3f 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Fix uk-ai workflow import and recompile lock file
60da2d6 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review May 17, 2026 21:43
Copilot AI review requested due to automatic review settings May 17, 2026 21:43
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 17, 2026

@copilot merge main, make build, make recompile

Done in 60da2d6. main is already up to date on this branch, make build passes, and make recompile now passes after fixing a broken import in uk-ai-operational-resilience.md and regenerating its lock file.

Copilot AI reviewed May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a BMAD-guided pull request review workflow and wires /bmad-review into centralized slash-command routing, alongside regenerated workflow lock artifacts.

Changes:

  • Adds bmad-pr-code-reviewer workflow source and compiled lock file.
  • Registers /bmad-review in agentic_commands.yml.
  • Regenerates several existing workflow lock files, including unrelated operational-resilience changes.
Show a summary per file
File Description
.github/workflows/bmad-pr-code-reviewer.md Defines the new BMAD-guided PR review workflow.
.github/workflows/bmad-pr-code-reviewer.lock.yml Compiled workflow artifact for the BMAD reviewer.
.github/workflows/agentic_commands.yml Adds centralized routing for /bmad-review.
.github/workflows/uk-ai-operational-resilience.md Removes an observability import from an existing workflow.
.github/workflows/uk-ai-operational-resilience.lock.yml Regenerated compiled artifact for the UK AI workflow.
.github/workflows/smoke-codex.lock.yml Regenerated lockfile heredoc identifiers.
.github/workflows/smoke-claude.lock.yml Regenerated lockfile cleanup step.
.github/workflows/smoke-call-workflow.lock.yml Regenerated lockfile heredoc identifiers.
.github/workflows/schema-feature-coverage.lock.yml Regenerated lockfile heredoc identifiers.
.github/workflows/necromancer.lock.yml Regenerated lockfile heredoc identifiers.
.github/workflows/duplicate-code-detector.lock.yml Regenerated lockfile heredoc identifiers.
.github/workflows/daily-observability-report.lock.yml Regenerated lockfile heredoc identifiers.
.github/workflows/daily-fact.lock.yml Regenerated lockfile heredoc identifiers.
.github/workflows/daily-cache-strategy-analyzer.lock.yml Regenerated lockfile heredoc identifiers.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 14/14 changed files
  • Comments generated: 2

Comment thread .github/workflows/uk-ai-operational-resilience.md
@@ -88,7 +88,6 @@ imports:
with:
title-prefix: "[uk ai resilience] "
expires: 3d
Comment thread .github/workflows/bmad-pr-code-reviewer.md Outdated
Comment on lines +55 to +57
3. Load BMAD reference material from `bmad-code-org/BMAD-METHOD`:
- `README.md` (required)
- If available, also load one or two docs files under `docs/` that clarify workflow philosophy.
@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented May 17, 2026

@copilot inline instructions

Copilot AI and others added 2 commits May 17, 2026 22:13
@pelikhan
Inline BMAD reviewer instructions
5b0c80e 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Clarify inline BMAD instruction reference
244e893 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 17, 2026

@copilot inline instructions

Done in 4de7018. I switched the BMAD reviewer workflow to inline-only instructions and removed runtime external instruction fetching; the workflow now explicitly points to Step 2 as the authoritative BMAD frame.

@pelikhan pelikhan closed this May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pelikhan pelikhan Awaiting requested review from pelikhan

Assignees

@pelikhan pelikhan

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pelikhan